test: Fix visionOS compilation of tests#7081
Merged
Conversation
philprime
force-pushed
the
philprime/fix-visionos-tests
branch
from
983947d to
e00f41d
Compare
- Added visionOS 26 configuration to GitHub Actions workflow. - Modified various files to support visionOS, including conditional compilation for UIKit and related tests. - Updated runtime context for Mac Catalyst to reflect correct descriptions. - Enhanced test coverage for device context on visionOS.
philprime
force-pushed
the
philprime/fix-visionos-tests
branch
from
e00f41d to
96db3d7
Compare
philprime
commented
Dec 22, 2025
philprime
commented
Dec 22, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7081 +/- ##
=============================================
- Coverage 84.867% 84.802% -0.066%
=============================================
Files 459 459
Lines 27517 27517
Branches 12130 12133 +3
=============================================
- Hits 23353 23335 -18
+ Misses 4122 3923 -199
- Partials 42 259 +217
... and 38 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
- Introduced a new destination configuration for visionOS Simulator in the sentry-xcodebuild.sh script.
philprime
requested review from
itaybre,
noahsmartin and
philipphofmann
as code owners
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
itaybre
reviewed
Dec 22, 2025
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| be9107c | 1223.63 ms | 1242.82 ms | 19.19 ms |
| 83cd14a | 1195.78 ms | 1222.06 ms | 26.29 ms |
| 7af87c1 | 1229.31 ms | 1253.84 ms | 24.53 ms |
| 7273bf4 | 1202.42 ms | 1227.62 ms | 25.21 ms |
| 8047b99 | 1226.37 ms | 1246.63 ms | 20.26 ms |
| b9aacb6 | 1230.42 ms | 1251.00 ms | 20.58 ms |
| cbbc82c | 1246.43 ms | 1266.13 ms | 19.70 ms |
| fb48c9a | 1232.49 ms | 1266.27 ms | 33.78 ms |
| 83d27f6 | 1233.56 ms | 1259.24 ms | 25.68 ms |
| 0b5fd21 | 1237.52 ms | 1251.36 ms | 13.84 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| be9107c | 23.75 KiB | 975.19 KiB | 951.44 KiB |
| 83cd14a | 24.14 KiB | 1.02 MiB | 1022.53 KiB |
| 7af87c1 | 23.75 KiB | 933.34 KiB | 909.59 KiB |
| 7273bf4 | 23.75 KiB | 908.01 KiB | 884.26 KiB |
| 8047b99 | 23.75 KiB | 855.37 KiB | 831.62 KiB |
| b9aacb6 | 23.75 KiB | 913.64 KiB | 889.89 KiB |
| cbbc82c | 23.75 KiB | 995.22 KiB | 971.47 KiB |
| fb48c9a | 23.75 KiB | 1006.34 KiB | 982.59 KiB |
| 83d27f6 | 23.75 KiB | 928.88 KiB | 905.13 KiB |
| 0b5fd21 | 23.75 KiB | 912.78 KiB | 889.03 KiB |
- Adjusted the runtime context's raw description for Mac Catalyst from "raw_description" to "mac-catalyst-app" in SentryHubTests and SentryCrashWrapperTests. - Modified conditional compilation in SentrySpan.m to exclude visionOS from UIKit checks.
Member
Author
|
need to revisit this PR because I just realized that my conditionals could enable/disable logic |
- Added entry to CHANGELOG for fixing `raw_description` in `runtime` context on Mac Catalyst. - Adjusted conditional compilation in various test files to improve compatibility with UIKit and visionOS.
Clear app start measurement in setUp() to prevent interference from previous tests that might have set it. This fixes a visionOS-specific test failure where testWaitingForFullDisplay_ReportFullDisplayBeforeInitialDisplay was failing when run with all tests due to incorrect tracer start timestamp. Also improve assertMeasurement helper to include file/line parameters for better test failure diagnostics.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
💡 Motivation and Context
While working on #6939 I noticed that tests were failing locally, and we didn't even have tests in CI.
💚 How did you test it?
📝 Checklist
You have to check all boxes before merging:
sendDefaultPIIis enabled.#skip-changelog